feat: Adds support for disabling Backup Compliance Policy on resource delete #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APIx bot: a message has been sent to Docs Slack channel |
EspenAlbert
approved these changes
Jan 10, 2025
themantissa
requested changes
Jan 10, 2025
internal/service/backupcompliancepolicy/resource_backup_compliance_policy.go
Show resolved
Hide resolved
Co-authored-by: Melissa Plunkett <themantissa@users.noreply.github.com>
lantoli
approved these changes
Jan 13, 2025
davidhou17
approved these changes
Jan 13, 2025
|
running tests in qa as dev is currently unstable: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/12752331915 |
themantissa
approved these changes
Jan 13, 2025
internal/service/backupcompliancepolicy/resource_backup_compliance_policy.go
Show resolved
Hide resolved
svc-apix-Bot
added a commit
that referenced
this pull request
Jan 14, 2025
lantoli
added a commit
that referenced
this pull request
Jan 16, 2025
* master: doc: Uses weekly option in cloud backup schedule documentation (#2963) chore: Bump tj-actions/verify-changed-files (#2965) chore: Bump srvaroa/labeler from 1.12.0 to 1.13.0 (#2966) chore: Bump peter-evans/create-pull-request from 7.0.5 to 7.0.6 (#2967) chore: Bump github.com/pb33f/libopenapi from 0.19.1 to 0.20.0 (#2968) chore: Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1 (#2969) fix: Updates test to use old schema for data sources in AWS provider configuration (#2962) chore: Uses backend default for zoneName to make tenantUpgrade pass on SDKv2 (#2952) chore: Refactors test checks to only run for TPF due to `[]` in SDKv2 for computed specs (#2955) chore: Ensures advanced configuration updates trigger wait for completion (#2954) chore: Remove usage of fixed 2024-08-05 version in cluster resource and ensure auto scaling mode is not impacted (#2918) chore: Updates CHANGELOG.md for #2953 feat: Adds support for disabling Backup Compliance Policy on resource delete (#2953) chore: Improves Makefile help (#2958)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s): CLOUDP-294102 (supporting new delete operation), CLOUDP-293109 (docs clarification)
Tested locally (cloud-dev) that the removal of the resource effectively disabled the Backup Compliance Policy in Atlas UI. In cloud-dev there is no pre-requisite of Disablement Approval. Internal KB has all the details of the process, mentioning how API delete operation fits in.
Type of change:
Required Checklist:
Further comments